search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
308 stars 36 forks source link

Gtk3 >= 3.20 theme issues #158

Open oleastre opened 6 years ago

oleastre commented 6 years ago

I finally updated my PhotoFlow package to version 0.2.8 for fedora 26. As fedora uses the latest gtk version I have problems with the current theme.

There are some missing backgrounds, ... see the attached screen shot.

photoflow-theme

I had a look at rawtherapee sources, they have a specific theme and loading code for gtk >= 3.20. Except for custom widgets and sizing issues (+margin, padding ... ), are there any other reason to have a specific theme ?

Would a theme based on Adwaita dark but enhanced with the custom part be a good solution ? I can provide the needed changes in the starting code, and a basic theme if needed.

aferrero2707 commented 6 years ago

If you have a good solution for providing a decent dark theme that works across different GTK3 versions, I would really appreciate! The current GTK3 theme is, if I remember correctly, a slightly modified copy of RT's TooWaBlue, but I have no objections to change it if that would provide a better GTK3 integration.

Thanks! And happy to hear that 0.2.8 has landed in the Fedora world!

jtojnar commented 6 years ago

Why force a custom theme? It looks reasonable with GTK built-in dark default theme. (I just deleted the contents of themes/photoflow-dark.css.)

screenshot from 2018-03-07 00-56-55