search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
315 stars 36 forks source link

i386 build #174

Closed salvadhor closed 5 years ago

salvadhor commented 6 years ago

I've revived PhotoFlow autobuild on Launchpad lately (PPA for Ubuntu/Mint). Unfortunately, i386 build fails with:

/Cr2Decompressor.cpp.o -c /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/Cr2Decompressor.cpp In file included from /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decoders/RawDecoderException.h:24:0, from /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/AbstractLJpegDecompressor.h:26, from /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/Cr2Decompressor.h:23, from /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/Cr2Decompressor.cpp:22: /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/AbstractLJpegDecompressor.h: In instantiation of ‘std::array<rawspeed::HuffmanTable, N_COMP> rawspeed::AbstractLJpegDecompressor::getHuffmanTables() const [with int N_COMP = 3]’: /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/Cr2Decompressor.cpp:119:37: required from ‘void rawspeed::Cr2Decompressor::decodeN_X_Y() [with int N_COMP = 3; int X_S_F = 2; int Y_S_F = 2]’ /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/decompressors/Cr2Decompressor.cpp:87:28: required from here /<>/photoflow-git-2.9+git20180129/src/external/rawspeed/src/librawspeed/common/RawspeedException.h:79:34: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘std::array<rawspeed::HuffmanTable, 4>::size_type {aka unsigned int}’ [-Werror=format=] rawspeed::ThrowException("%s, line " STR(LINE) ": " fmt, \



(full log https://launchpadlibrarian.net/355135218/buildlog_ubuntu-artful-i386.photoflow-git_1%3A2.9+git20180129-1218~ubuntu17.10.1_BUILDING.txt.gz)

Is that mean that support for i386 is dropped?
aferrero2707 commented 5 years ago

Closing since maintaining and testing the i386 compatibility is currently too much effort.