search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
315 stars 36 forks source link

error: undefined symbol: PF::version_string #190

Open yurivict opened 5 years ago

yurivict commented 5 years ago

Link fails on FreeBSD:

ld: error: undefined symbol: PF::version_string
>>> referenced by mainwindow.cc
>>>               mainwindow.cc.o:(PF::MainWindow::MainWindow()) in archive src/libpfgui.a
aferrero2707 commented 5 years ago

Could you please provide me the whole cmake and make logs? Thanks!

yurivict commented 5 years ago

This patch solved the problem:

@@ -482,7 +482,7 @@ ENDIF(APPLE)
 #
 # photoflow executable
 #
-add_executable(photoflow main.cc ${RESOURCE_OBJECT})
+add_executable(photoflow main.cc version.cc ${RESOURCE_OBJECT}) # https://github.com/aferrero2707/PhotoFlow/issues/190
 IF(APPLE)
   set_target_properties(photoflow PROPERTIES LINK_FLAGS " -framework ApplicationServices ")
 ENDIF(APPLE)

You didn't add version.cc to build commands.

aferrero2707 commented 5 years ago

version.cc is included at either lines 222 or 224 in src/CMakeLists.txt, but something seems to go wrong on FreeBSD... that's why I am interested in the cmake log, and possibly also the cmake parameters you are using.

aferrero2707 commented 5 years ago

@yurivict are there any news? Could you provide me the cmake log and the cmake invocation parameters you are using?

Thanks!

aferrero2707 commented 5 years ago

@yurivict bumping this thread to see if there are any news...