aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
315 stars 36 forks source link

some problems under ubuntu 14.04 #47

Closed revast closed 9 years ago

revast commented 9 years ago

1: Interface does not come up when not adding an image at startup. qt 5.3.2. It builds up the frames, but then disappears. 2: when adding image, it comes up, but tools sidebar to the right is missing, and there is no way to get it??? 3: /usr/share/photoflow/themes/photoflow-dark.gtkrc:580: error: invalid string constant "notebook-close", expected valid string constant no other errors in debug output...

does not matter whether I am using dhor/myway or anton+/photo-video-apps ppas

aferrero2707 commented 9 years ago

1: could you try starting photoflow from the terminal, and copy/paste the console messages? I've never observed such misbehavior...

2: to open the toolbar on the right you need to double-click on the name of some layer on the left. This will open the widget with the corresponding controls on the right (see here for details). Did you try that already?

3: to be fixed, but not "dangerous"...

revast commented 9 years ago

photoflow exePath: /usr/bin exePath: /usr/bin Starting image processor... ImageProcessor::ImageProcessor(): starting thread ImageProcessor::ImageProcessor(): thread started Image processor started. locale dir: /usr/share/locale Calling ImageProcessor::instance().run() ImageProcessor started. stat_result=0 /usr/share/photoflow/themes/photoflow-dark.gtkrc:580: error: invalid string constant "notebook-close", expected valid string constant

program runs, but does not show up. I am on xfwm4, xfce4.12 right now. I now experienced the same behavior of window not coming up, now also when adding a filepath behind. Quitting with ctrl c, Next time I tried it worked again, with photoflow giving me opportunity to rescue the file.. But then I tried to switch to openbox wm and to launch it again, then it works as expected.. so no closing even if no filepath added...looks like a xfwm4 issue?

aferrero2707 commented 9 years ago

It could indeed be a WM issue... at least I have now some direction to go to investigate the issue. However, I need to get my hands on an XFce box first. I've tested the app with Mate and Cinnamon under Mint 17 and it works, although some other user reported issues with the theme when using Cinnamon under Ubuntu.

Joermungand commented 9 years ago

I am not on Ubuntu, but on Arch with the latest XFCE. The window eventually comes up, but only after xfwm4 segfaults. It turns out the problem lies with the gtkrc theme. If I remove it everything works just fine.

aferrero2707 commented 9 years ago

I've just tested with Xfce under Ubuntu 14.04, and I have no problems running photoflow with the custom theme... do you have the murrine theme engine installed in your system? It is needed by the custom theme, but it is not included in the package dependencies (it should probably be added...).

Joermungand commented 9 years ago

The murrine engine is installed all right. However, running the package in Openbox will not trigger a segfault or any other error apart from the "notebook-close" one, which is probably due to the fact that the corresponding section in the gtkrc has been commented out, so the notebook-close style is no longer defined.

Joermungand commented 9 years ago

Inching closer. It seems that what pisses off xfwm4 is the event sent in main.cc. I’ve built PhotoFlow with the line containing ‘gdk_event_send_clientmessage_toall’ (line 212 in main.cc) edited out. The results: xfwm4 no longer segfaults while the custom theme is appropriately applied. Same behaviour on Openbox.

aferrero2707 commented 9 years ago

I have tried to comment out this line in my Mint 17 system, and the custom theme gets still loaded as well... I took this line from some GTK example, but maybe it is not really necessary after the call to Gtk::RC::reparse_all().

I will leave it commented in the stable branch, to see if other users eventually report a regression on other systems.

Joermungand commented 9 years ago

Apparently, it isn’t – rather detrimental. I’ve absolutely no experience with GTK programming, so I’ve no clue about how it is actually supposed to work. I’ll update the PKGBUILD, see what gives.

aferrero2707 commented 9 years ago

Removing the call to gdk_event_send_clientmessage_toall() seems to fix things under Xfce without bad side effects, so I'll close the issue as solved.