search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
315 stars 36 forks source link

PhotoFlow freaks out when it has to display too many pixels #51

Open CarVac opened 8 years ago

CarVac commented 8 years ago

Version: 0.2.4-1dhor~vivid

With 1:1 view on my 4k screen, less than half of what should be visible in the photo actually gets painted. The rest is either black or gibberish.

See photo:

http://i.imgur.com/W6snk8p.jpg

If I zoom out once, all but the very top gets painted correctly.

If I zoom out to fit (smaller than that), the whole image is visible.

aferrero2707 commented 8 years ago

I suspect that this comes from the output buffer that is used to cache the pixels that are displayed on screen, and that is probably too small to hold the 4k screen size. I'll see how to make the buffer dynamically adapting to the actual screen size.

I wonder what are the performances of the program with all those pixels to be displayed and computed at the same time... I never had the chance to make tests on such an high-res screen.

CarVac commented 8 years ago

How much memory pressure is there that you can't cache the whole image size?

Does it cache every layer as well?

aferrero2707 commented 8 years ago

The memory usage is not a problem in itself, as there is very little memory caching of layer data going on... in fact, one can probably edit an 100 megapixels image with as little as 500 megabytes of RAM.

It is just that I did not consider the 4k screens when setting the maximum size of image caching for screen preview, and this can be (and will be) easily fixed in next version.

CarVac commented 8 years ago

Keep in mind that there exist 5k screens and eventually 8k is going to be coming...