OSX Build - Stable Branch GIMP/Gegl Errors

[Partha1b]

I am having the following error building on a Mac:

/Users/partha/projects/src/gimp/plug-ins/Useful-Plugins/PhotoFlow/src/plugin/pfgimp.cc:372:9: error: taking the address of a temporary object of type 'GeglRectangle' (aka '_GeglRectangle') [-Waddress-of-temporary] GEGL_RECTANGLE(0, 0, width, height), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ and /Users/partha/projects/src/gimp/plug-ins/Useful-Plugins/PhotoFlow/src/plugin/pfgimp.cc:396:21: error: no matching function for call to 'gimp_parasite_new' exif_parasite = gimp_parasite_new("exif-data", ^~~~~~~~~~~~~~~~~

My details:

clang --version Apple LLVM version 7.0.2 (clang-700.1.81) Target: x86_64-apple-darwin15.2.0 Thread model: posix

[aferrero2707]

Hi!

Both compilation issues should be fixed in current stable branch (see commit https://github.com/aferrero2707/PhotoFlow/commit/25055a65ae45687b333ad549147bb7fe102015b5).

[Partha1b]

Cool. It wasn't fixed last night. :)

Thanks!

[aferrero2707]

You are welcome, I actually fixed it on the fly after your message...

May I ask if you are planning to include photoflow (and the gimp plug-in) in your set of windows and OSX packages?

[Partha1b]

Elle Stone contacted me and asked me if I'd look into it and so I started looking at PhotFlow. I was not familiar with your package.

If you have no objections, I would be happy to do it.

On Mon, Jan 4, 2016 at 8:44 AM, aferrero2707 notifications@github.com wrote:

You are welcome, I actually fixed it on the fly after your message...

May I ask if you are planning to include photoflow (and the gimp plug-in) in your set of windows and OSX packages?

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/62#issuecomment-168679059 .

[aferrero2707]

On the contrary, I would be more than thankful!

I've been able so far to provide my own OSX and windows packages, but:

• the windows version is cross-compiled with mingw under linux, so probably not optimized at its best
• I have not yet managed to provide packages for the GIMP plug-in, and I'm not sure how to do that.

[Partha1b]

Thanks! I will definitely help out anyway I can. I build natively on Windows and OSX by compiling and optimizing each build and dependencies almost identically.

I host my own website and so would be happy to mirror you and provide my builds of PhotFlow on my site.

On Mon, Jan 4, 2016 at 9:13 AM, aferrero2707 notifications@github.com wrote:

On the contrary, I would be more than thankful!

I've been able so far to provide my own OSX and windows packages, but:

• the windows version is cross-compiled with mingw under linux, so probably not optimized at its best
• I have not yet managed to provide packages for the GIMP plug-in, and I'm not sure how to do that.

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/62#issuecomment-168687281 .

[Partha1b]

Hi Andrea,

Finally had the time to upload all my builds. :) Includes your PF as the default Raw editor.

Thanks, Partha

On Mon, Jan 4, 2016 at 9:39 AM, Partha Bagchi partha1b@gmail.com wrote:

Thanks! I will definitely help out anyway I can. I build natively on Windows and OSX by compiling and optimizing each build and dependencies almost identically.

I host my own website and so would be happy to mirror you and provide my builds of PhotFlow on my site.

On Mon, Jan 4, 2016 at 9:13 AM, aferrero2707 notifications@github.com wrote:

On the contrary, I would be more than thankful!

I've been able so far to provide my own OSX and windows packages, but:

• the windows version is cross-compiled with mingw under linux, so probably not optimized at its best
• I have not yet managed to provide packages for the GIMP plug-in, and I'm not sure how to do that.

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/62#issuecomment-168687281 .