pfgimp crashes on exit - Windows 64bit

[Partha1b]

I used pfgimp as part of my GIMP build. GIMP was git pulled on Sunday.

pfgimp works fine but crashes on exit. That is when you press "OK" it does not send data to GIMP and crashes.

[aferrero2707]

I Will investigate from my side. Meanwhile, would int be possibile for you to send me a copy of the console messages that are produced before the crash?

Thanks!

[Partha1b]

My GIMP builds automatically create a logfile. Here is everything from that run:

http://www.partha.com//temp/__gimp-2.9-run.log.7z

On Tue, Feb 2, 2016 at 2:07 AM, aferrero2707 notifications@github.com wrote:

I Will investigate from my side. Meanwhile, would int be possibile for you to send me a copy of the console messages that are produced before the crash?

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/71#issuecomment-178414275 .

[aferrero2707]

I've been able to reproduce and fix the problem under Linux. Could you check if my fixes work for the Windows version as well? The stable branch is already updated.

Thanks!

[Partha1b]

Sorry Andrea, it's still crashing. :(

Here is the logfile.

http://www.partha.com//temp/PhotoFlow-gimp-plugin-01.txt

On Tue, Feb 2, 2016 at 6:02 PM, aferrero2707 notifications@github.com wrote:

I've been able to reproduce and fix the problem under Linux. Could you check if my fixes work for the Windows version as well? The stable branch is already updated.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/71#issuecomment-178875355 .

[aferrero2707]

Well, we have at least moved forward with respect to the initial crash... I found another bug in my code that could explain the crash on exit: the Gtk GUI object were destroyed inside a thread other than the main one. I have now moved the whole clean-up on exit into the main thread, and did not see any more random crashes under Linux. Let's see if it finally work on your system as well.

Thanks for your perseverance!

[Partha1b]

i think there is still some issue. It's still crashing. :(

Here is the logfile:

http://www.partha.com/temp/PhotoFlow-gimp-plugin-02.txt

On Wed, Feb 3, 2016 at 10:35 AM, aferrero2707 notifications@github.com wrote:

Well, we have at least moved forward with respect to the initial crash... I found another bug in my code that could explain the crash on exit: the Gtk GUI object were destroyed inside a thread other than the main one. I have now moved the whole clean-up on exit into the main thread, and did not see any more random crashes under Linux. Let's see if it finally work on your system as well.

Thanks for your perseverance!

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/71#issuecomment-179296444 .

[aferrero2707]

Ok, that's a bit frustrating... but at least your log file shows the exact place where the code stops. I've removed one more suspicious line of code and added further debugging messages to pin down the crash, which seems to happen in the PhotoFlow::close() method.

Thanks!

[Partha1b]

OK, that seems to have cured the issue. No more crashes. :)

However, we have another issue:

1. Start GIMP and open image.
2. pfgimp starts correctly.
3. Hit cancel. Now pfgimp closes but leaves behind a small black image in GIMP.

On Thu, Feb 4, 2016 at 1:56 AM, aferrero2707 notifications@github.com wrote:

Ok, that's a bit frustrating... but at least your log file shows the exact place where the code stops. I've removed one more suspicious line of code and added further debugging messages to pin down the crash, which seems to happen in the PhotoFlow::close() method.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/71#issuecomment-179677417 .

[aferrero2707]

Bingo!!! That's a really good news!

The black image is "normal", in the sense that it is a temporary work around until I figure out how to correctly tell gimp that no image was generated.

Now that the crashes are hopefully fixed I can look into that, but I consider that a "minor issue".

Thanks!