search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
309 stars 36 forks source link

Some G'MIC Commands That Aren't Filters Can Do Strange Things #9

Closed grosgood closed 9 years ago

grosgood commented 9 years ago

I have doubts if the use case for writing G'MIC pipelines will be worth the pain. Many G'MIC commands have nothing to do with filtering -reversing two images on a G'MIC image list? Program flow control commands like -repeat...-done, -local...endlocal? the 3D volumetric commands? I used the G'MIC command -x_paint, which, when used in a shell and when there is access to the display, puts up a cute little paint program, but simply functions as a layer scrambler in PhotoFlow. It has it uses on the command line, but in Photoflow? You already have a little paint program for making masks and such. I saw the -Dgmic_display=0 in the compiling command lines, but that does not seem to quite quiese x_paint and friends. The video in the documentation shows what -x_paint does when it becomes the operator in a layer. In my own humble opinion, wrapping G'MIC commands up in filters and giving the end users a GUI is probably going to protect your sanity. If you borrow from the Gimp/Krita filters, you've got GUI's that many people are already pretty familiar with and it wraps up the G'MIC commands so that nobody can inadvertently misuse them. David T. may feel differently on this point and he is always worth listening to, but I'm not sure that I'd want to expose the whole G'MIC interpreter to non-programming photographers and the like. Just my two American cents, whatever that might be worth in Euros.

Hardware and build: Exact same as what I entered in issue #8 Documentation: https://backup.filesanywhere.com/fs/v.aspx?v=8c72658c5a6271b5a4ac

  1. x_paintdemo.mp4 2:29 entering into a layer a G'MIC non-filtering command - x_paint.
  2. brisbane_nsw.jpg - test image
aferrero2707 commented 9 years ago

I fully agree, and actually the generic G'MIC interface is more like a dirty hack for myself (and other experts) to quickly test a filter without adding 4 new source files... it will eventually disappear, or be kept in some testing branch, as soon as one can consider the progam "production-ready"...

The filters that are already wrapped have gui configuration dialogs that try to closely match those of the gimp g'mic plugin.

By the way, have you tried photoflow's painting tool already? Does it work for you?