search

aferrero2707 / PhotoFlow

A fully non-destructive photo retouching program providing a complete layer-based workflow including RAW image development.
http://aferrero2707.github.io/PhotoFlow
GNU General Public License v3.0
309 stars 36 forks source link

Artefacts along image edges after latest commit to stable #91

Closed Joermungand closed 8 years ago

Joermungand commented 8 years ago

After the latest commit to the stable branch, raw images load very quickly, but artefacts show up along all image edges (same as in issue #58, which I filed back in December).

aferrero2707 commented 8 years ago

I'm looking into that...

aferrero2707 commented 8 years ago

I cannot reproduce the issue with the current stable branch. Could you provide me a sample RAW file for which the problem appears?

Also, do you have just artefacts or also extra black margins, like in issue #58? If there are only artefacts but no extra margin, then the reason is a remaining bug in the fast demosaicing routine I am using to render RAW images at zoom levels below 1:1. I'll fix that before next release.

Thanks!

Joermungand commented 8 years ago

It happens with any RAW image I’m trying to open. There are no extra black margins, only the artefacts, and they do disappear when zooming at 1:1. They are Canon CR2 files. Here’s a link to a sample off Dropbox:

https://www.dropbox.com/s/m4r0yawuw52z719/IMG_3602.CR2?dl=0

On 05/05/16 15:18, aferrero2707 wrote:

I cannot reproduce the issue with the current stable branch. Could you provide me a sample RAW file for which the problem appears?

Also, do you have just artefacts or also extra black margins, like in issue #58 https://github.com/aferrero2707/PhotoFlow/issues/58? If there are only artefacts but no extra margin, then the reason is a remaining bug in the fast demosaicing routine I am using to render RAW images at zoom levels below 1:1. I'll fix that before next release.

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/91#issuecomment-217138913

aferrero2707 commented 8 years ago

Then this issue is only related with the fast demosaicing, not with RawSpeed itself... I'll try to push a fix this evening.

Moreover, the artefact does not affect exported images.

Joermungand commented 8 years ago

Right, exported images are OK.

On 05/05/16 16:28, aferrero2707 wrote:

Then this issue is only related with the fast demosaicing, not with RawSpeed itself... I'll try to push a fix this evening.

Moreover, the artefact does not affect exported images.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/91#issuecomment-217154511

aferrero2707 commented 8 years ago

It should be fixed in the stable branch, as well as a similar corrupted border issue with the IGV demosaicing.

Joermungand commented 8 years ago

Fixed! Tahnks! Pushed to AUR.

On 05/05/16 21:17, aferrero2707 wrote:

It should be fixed in the stable branch, as well as a similar corrupted border issue with the IGV demosaicing.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aferrero2707/PhotoFlow/issues/91#issuecomment-217231625

aferrero2707 commented 8 years ago

Great! Then I close the issue.