Open ukleinek opened 4 years ago
Merging #271 into master will decrease coverage by
0.10%
. The diff coverage is16.66%
.
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
- Coverage 40.51% 40.40% -0.11%
==========================================
Files 30 30
Lines 980 980
==========================================
- Hits 397 396 -1
- Misses 583 584 +1
Flag | Coverage Δ | |
---|---|---|
#unittests | 40.40% <16.66%> (-0.11%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
afew/filters/MeFilter.py | 38.88% <16.66%> (-5.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2476428...c6b3da5. Read the comment docs.
Hello @ukleinek First and foremost thank you for the interest and you submited patches on the project :+1:
Note this is completely untested, so please look deeply before merging :-)
Yes actually there was some significant progress on the tests side of the project, so creating a test for the MeFilter seems a fair preriquisite to merge this PR.
I will comment the diff.
Also ping @aidecoe original author of this filter
Hi ukleinek. What is the improvement? Or is it just a code refactor?
Note this is completely untested, so please look deeply before merging :-)