search

afewmail / afew

an initial tagging script for notmuch mail
ISC License
325 stars 98 forks source link

Spam filter to work with flags from Rspamd and bogofilter #300

Open Titan-C opened 4 years ago

Titan-C commented 4 years ago

I started using bogofilter as it is low on resources, and enough for my email load. I realized I was missing other header matching options for spam.

This also Closes #299, for Rspamd

P.S. Happy if you also give this PR a hacktoberfest-accepted label

codecov[bot] commented 4 years ago

Codecov Report

Merging #300 into master will decrease coverage by 0.21%. The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   47.08%   46.86%   -0.22%     
==========================================
  Files          30       30              
  Lines        1079     1084       +5     
==========================================
  Hits          508      508              
- Misses        571      576       +5
Flag Coverage Δ
#unittests 46.86% <25.00%> (-0.22%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
afew/filters/HeaderMatchingFilter.py 33.33% <0.00%> (-8.78%) :arrow_down:
afew/filters/SpamFilter.py 60.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3aa987...5c58e18. Read the comment docs.

GuillaumeSeren commented 4 years ago

Hello @Titan-C thank you for this patch.

It look's fine to me but this filter does not have test (yet) so I will wait for a second advice to merge it.

@flokli if you want to look at it ?