afewmail / afew

an initial tagging script for notmuch mail
ISC License
325 stars 98 forks source link

Handle DMARC report with empty spf or dkim XML nodes #305

Closed aidecoe closed 1 year ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #305 (41cf246) into master (c6a5b29) will decrease coverage by 0.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   47.08%   46.99%   -0.09%     
==========================================
  Files          30       30              
  Lines        1079     1081       +2     
==========================================
  Hits          508      508              
- Misses        571      573       +2     
Flag Coverage Δ
unittests 46.99% <0.00%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
afew/filters/DMARCReportInspectionFilter.py 24.28% <0.00%> (-0.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6a5b29...41cf246. Read the comment docs.

GuillaumeSeren commented 3 years ago

Hey @aidecoe , since this filter doesn't have a test yet how do you feel about adding one while working on this issue ?

aidecoe commented 3 years ago

Adding another one would be trivial for this case, but to start, it's quite an effort. I needed the quick fix to unblock processing of my mail and so I shared it here. If you don't mind keeping it open for a while, I'll add tests when I get a chance.

GuillaumeSeren commented 3 years ago

@aidecoe Yes I know it is an effort but if it can be done it would be so much better.