Closed tohojo closed 9 months ago
Hello, thank you for the patch.
This look like improvement to me but I would like this code to test covered, do you mind adding a test for this ?
Guillaume Seren @.***> writes:
Hello, thank you for the patch.
This look like improvement to me but I would like this code to test covered, do you mind adding a test for this ?
Sure, PTAL :)
Hey @tohojo , Thank you for the upgraded patch with the test support for this case.
It is LGTM :+1:
Notmuch can raise a NullPointerException when trying to read a non-existent header from a message. Gracefully handle this in the HeaderMatchingFilter by just aborting processing when encountering such an error.