Closed havardAasen closed 10 months ago
Hey @havardAasen , last master push was again 3.8 to 3.12 https://github.com/afewmail/afew/actions/runs/5391100743
Can you provide more precision on this issue ?
Thank you
I'll add a photo, perhaps it describe the problem better.
In short, the Ci pipeline is configured incorrectly. You believe it tests 3.8 to 3.12 but it only tests against 3.8
This is the last job for the master branch, claimed to build and test against 3.12, but in reality it is 3.8 https://github.com/afewmail/afew/actions/runs/6945577376/job/18895266536#step:6:16
@GuillaumeSeren
I see you haven't removed the waiting-reply
label, are you unsatisfied with the one i provided?
Hey @havardAasen , yes sorry I didn't understand the issue on the first post.
So it seems the test are always run on python-3.8 for some reason, it is not supposed to be like that, we have to investigate.
Oh I think I get it, after searching and debugging the ci file, there was a big issue, thank you taking the time to report this :clap:
The issue was, in the following code of the runner:
- name: Set up Python
uses: actions/setup-python@v1
with:
python-version: '${{ matrix.python }}'
# But the name of the list of available python version defined earlier
# in the file is python-version
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
After fixing the variable we can now see the right python version, and discover a issue on python-3.12.
Even though the header reads Python versions ranging from 3.8 to 3.12, it is only testing towards Python 3.8. This is seen during test, build and install stage. I suspect that the pipeline for Python 3.12 will fail if it would be tested.
There is also some deprecation warnings regarding
actions/checkout@v2
andactions/setup-python@v1
.