affederaffe / CustomPlatforms

A BSIPA Plugin for Beat Saber that adds support for custom environments (platforms)
GNU General Public License v3.0
35 stars 9 forks source link

Custom Platforms not Initializing in some environments + V3 Env Issues #25

Open SyncBS opened 1 year ago

SyncBS commented 1 year ago

Custom Platforms do not get initialized unless the player restarts the map through the pause menu on the following platforms:

The First; Origins; Triangle; Nice; Big Mirror; Dragons; Monstercat; Crab Rave; Panic; Green Day; Timbaland; Fit Beat; Kaleidoscope; Skrillex;

And for V3 Environments it initializes properly except no existing objects are removed so the Custom Platform is just added on top of the environment.

Here's a video of me testing with a platform that can be found on model saber and it's link as well as the log file for the testing: https://modelsaber.com/Platforms/?id=1618413935&pc https://streamable.com/n7oq9f _latest.log

qqrz997 commented 6 months ago

as for the v3 environments, the environment hider script hasn't been updated for a long long time. i'm considering making a separate library for handling this part of the mod so that it can be updated without having to change custom platforms itself

affederaffe commented 6 months ago

Realistically, we should probably detect if a map uses v3 events and don't use a custom platform then since they will be incompatible anyways, resulting in no effects at all. (Correct me if I'm wrong, I haven't kept up with the latest changes)

qqrz997 commented 6 months ago

that was something i'd considered but it can kinda work. if a mapper chooses to use a custom platform for whatever reason, instead of chroma for instance, there's a lot of flexibility in v3 lights such that it would be possible to integrate them alongside a platform. maybe instead check if the map is using environment enhancements from chroma? it allows people to edit and duplicate environment object from what i can gather, so trying to load platforms on these kind of maps could be considered a conflict.

qqrz997 commented 6 months ago

as an example here is a video of the lattice environment used in OST 6, with mawntee's neonwave sunset platform. lattice is essentially a completely blank slate with 4 sets of 8 cubes where the lights emit from, and some track lights. basically, you can make the 'lattice' lights to go anywhere, so they typically wouldn't fit under the Custom Platform's normal config, but, you could fit the track lights into the hide center lights group.

another idea is making a v2 of custom platforms with a new project to boot with more generic settings based on what certain lights do or where they appear in the world. i imagine that would take quite a bit of effort, but could ensure new platforms are more future proof.

qqrz997 commented 5 months ago

with some quick testing the original bug with platforms not being initialized doesn't seem to happen with the updates made. tested on beat saber 1.37.0

custom platforms should get released sooner rather than later so that people making new platforms have all the more reason to use shaders that support SPI, and i think it's in a good enough state to release

speedymlg commented 3 months ago

Ive found out the conflicting mod that causes platforms not initiating on some environments. It is the optimization function of the "GottaGoFast" mod. (for 1.29.1)