search

affederaffe / Tmds.DBus.SourceGenerator

A roslyn source generator for creating proxies targeting the Tmds.DBus.Protocol API
MIT License
7 stars 5 forks source link

INPC for Handlers #22

Closed jmacato closed 2 months ago

jmacato commented 3 months ago

Was wondering if it's good to have INPC available for Handler objects so we could properly interface with propchanges notifications

affederaffe commented 3 months ago

Would making handler properties abstract work? For properties where no change notifications are required, one would simply implement an auto-property, not awfully cluttering the code and where desired, the setter may be used.

jmacato commented 3 months ago

Yeah i think that would be reasonable enough 🙏

affederaffe commented 2 months ago

With https://github.com/affederaffe/Tmds.DBus.SourceGenerator/commit/6c3feb9692c69f4d001bc1cd4036621d939c6b26, every settable property is now abstract so that one can implement a custom setter that one may emit change notifications. Does this work for your use-cases?

jmacato commented 2 months ago

Hi @affederaffe Sorry for the late reply, Yes i believe that is quite sufficient for our use case :pray: