affinityworks / main

Tools for building collaborative advocacy and social change.

https://affinity.works

GNU Affero General Public License v3.0

53 stars 13 forks source link

resolve #579 - "welcome email for new group members" #681

Closed aguestuser closed 6 years ago

aguestuser commented 6 years ago

resolve #579

Notes

create join_group_email that provides all links specified in Acceptance Criteria for #677
send this email in Members::AfterCreate
refactor Subgroups::AfterCreate to also send this email (ie: send same email whether you created a group or joined one)

side-effects:

add unit tests for Members::AfterCreate
light touch-up to Subgroups::AfterCreate unit tests
rename mailer classes, methods
streamline dev env invocations of resque

QA Instructions

For group join form

if a user already exists with email you want to use, destroy it
go to /groups/2/join
fill out form using an email you control
check to see if you got a welcome email

For bulk import script

destroy the person you just created in last test
follow the happy path QA instructions in #680
check to see if you got a welcome email

Screenshot

join-group-email