afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

BUG: JSON fiducial order #106

Closed kaitj closed 3 years ago

kaitj commented 3 years ago

The problem

The order of the fiducials when it is saved matters for the JSON file. Currently parsed by index (no other key to delineate between different fiducials) before checking labels. Not sure if there is a way around this, but if not we should implement a check to ensure they are in the correct order!

This can be tested by converting the valid_flip.fcsv to a json file and running it through validator on the afids-class branch.

Environment

_PR template was adopted from appium_

kaitj commented 3 years ago

This is resolved in 27fb95b. Should have made use of the identified fiducial label instead of relying on the index used to parse through json