BUG: Fix mismatched columns

kaitj commented 3 years ago

Proposed changes

Resolves #93

Error is thrown if row_label is not numerical / row_desc is empty. Adds check for both of these. Recommendation is to merge following #101

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionalitiy)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

[x] Changes have been tested to ensure that fix is effective or that a feature works.
[x] Changes pass the unit tests
[x] Code has been run through black with the -l 79 flag.
[x] I have included necessary documentation or comments (as necessary)
[ ] Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

_PR template was adopted from appium_

kaitj commented 3 years ago

Just realized this includes all the commits from the afids-class PR so definitely don't merge until #101 is merged!

kaitj commented 3 years ago

A couple of nitpicks but basically looks good.

If possible, it would be nice to change this PR to merge into the afids-class branch instead of master -- I think that would get rid of all the irrelevant commits.

Done!

afids / afids-validator