search

afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Clean up the repo #11

Closed tkkuehn closed 5 years ago

tkkuehn commented 5 years ago

Finally diving into the code and had a few project structure type suggestions to make.

I've tested this on my own PythonAnywhere and verified that it still runs given the right WSGI configuration.

The only change is that you now need to point path at wherever the fidvalidator directory is - it doesn't have to be in / anymore, as I think it did before.

kaitj commented 5 years ago

d96f694 - For requirements.txt, can we confirm this will run with just these 3 requirements (had also added in a requirements.txt in #9, but had a lot more added to get working for virtualenv).

1a50dbf Agree with this, if it isn't necessary to set up the site.

06d7590 If the WSGI file isn't needed for production then getting rid of it seems like a good idea.

4c5e0d7 For organizational purposes, I think this can be left as is or cleaned up a little bit so that the folder names have some meaning to the files that are within it.

tkkuehn commented 5 years ago

d96f694 - I've gotten it working in a venv on my machine and PythonAnywhere. Everything in 758d3b not in this one except Flask-WTF is a requirement of Flask, and I don't think Flask-WTF is used anywhere.

06d7590 - You still need it for production, but it's automatically generated by PythonAnywhere.

4c5e0d7 - ~My main motivation here is that I don't see what would be outside whatever we would rename home/fidvalidator except README.md, so we could do that but I don't think we would gain that much.~ On second thought, I think just putting everything except README.md and requirements.txt under a fidvalidator directory would be good to allow us to have a separate tests directory an other stuff, like in the flask tutorial project layout page.