This resolves the actions bug with triggering on draft. Removed the additional conditionals ([skip ci] and [wip]) as it caused the actions to always trigger. [skip ci] is actually built into GH actions now, so we don't need to separately check for that tag. I've suggested in the contributing docs to either add [skip ci] to commit messages or to use a draft PR for WIP material.
One thing I did not include is the output of the payload information to debug actions. I think this something that should added to one's own fork for testing github actions rather than including here. We can however include it if others feel like we should. Not sure how it handles secrets stored in the environment (e.g. passwords, keys, for triggering heroku deployment).
Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionalitiy)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!
[x] Changes have been tested to ensure that fix is effective or that a feature works.
[ ] Changes pass the unit tests
[ ] Code has been run through black with the -l 79 flag.
[x] I have included necessary documentation or comments (as necessary)
[ ] Any dependent changes have been merged and published
Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
CI currently failing on black as it's not set up to check from a forked branch. This may be something to look into in the future, but I don't think it should prevent us from merging this in.
Proposed changes
This resolves the actions bug with triggering on draft. Removed the additional conditionals (
[skip ci]
and[wip]
) as it caused the actions to always trigger.[skip ci]
is actually built into GH actions now, so we don't need to separately check for that tag. I've suggested in the contributing docs to either add [skip ci] to commit messages or to use a draft PR for WIP material.One thing I did not include is the output of the payload information to debug actions. I think this something that should added to one's own fork for testing github actions rather than including here. We can however include it if others feel like we should. Not sure how it handles secrets stored in the environment (e.g. passwords, keys, for triggering heroku deployment).
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!black
with the-l 79
flag.Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
_PR template was adopted from appium_