afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

MAINT: clean up requirements.txt #131

Closed kaitj closed 3 years ago

kaitj commented 3 years ago

Proposed changes

Resolves #126 and retains the bare minimum packages required to set up the environment. Some of the packages previously listed are still installed, but were probably added to the requirements as part of a pip freeze

Packages identified by setting up a clean environment and installing missing packages as it came up when trying to run app locally.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

_PR template was adopted from appium_

kaitj commented 3 years ago

Ahh yeah, I guess I forgot to try uploading to database. I've added psycopg2 to the requirements in d238063.

My machine running Python 3.9 isn't compatible with numpy 1.17 anymore, maybe we could think of using numpy~=1.17 instead, and even adopting ~= more widely?

Yeah that sounds good. I've made the changes in the same commit to use ~=. Definitely prefer this to >= to ensure we don't accidently upgrade to a major change breaking existing functionality. I've been testing in Python 3.8 - none the less, running pip install -r requirements.txt installs the following for me:

Successfully installed Flask-1.1.4 Flask-Migrate-2.7.0 Flask-SQLAlchemy-2.5.1 
Flask-Script-2.0.6 Jinja2-2.11.3 Mako-1.1.4 MarkupSafe-2.0.1 SQLAlchemy-1.4.15 
WTForms-2.3.3 Werkzeug-1.0.1 alembic-1.6.4 click-7.1.2 greenlet-1.1.0 
itsdangerous-1.1.0 numpy-1.20.3 plotly-4.14.3 psycopg2-binary-2.8.6 python-dateutil-2.8.1 
python-editor-1.0.4 retrying-1.3.3 six-1.16.0