afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Fix Bump Version #174

Closed kaitj closed 2 years ago

kaitj commented 2 years ago

Proposed changes

Fixes a bug with github action causing deployment to fail. Instead of checking for and replacing punctuation in the search and replace, just searches for version numbers (including *-pre.*). This change also reverts the release version back to v1.2.2-pre.1 prior to the deployment workflow breaking.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

_PR template was adopted from appium_

kaitj commented 2 years ago

Hmm, you might be right about the regex - I haven't tested this on this repo since the change and was just copied over from the snakebids repo (yay github actions testing). There are some noted differences in the two repos, but I think it should work? Might be best to either test this on a fork or if we have some time to sit down and try to fix this live.

tkkuehn commented 2 years ago

Just going to give this a shot and roll it back if it breaks