afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Add new template fiducials #176

Closed tkkuehn closed 2 years ago

tkkuehn commented 2 years ago

Proposed changes

Add all the templates from https://github.com/ataha24/afids-data/tree/main/data/templates to the validator

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

_PR template was adopted from appium_

tkkuehn commented 2 years ago

Note: After talking to Alaa, we want to keep the existing versions of Agile12v2016 and Colin27, but update PD25, so that's what's in the PR now. If it still looks good we can merge

kaitj commented 2 years ago

Still looks good to me. And yeah, we can merge - I forgot the workflow will deploy to the test application and we would need to manually run the deployment to production app

tkkuehn commented 2 years ago

Yeah after merging I'll take a look at the test version then deploy. Thanks!