Closed tkkuehn closed 2 years ago
Will take a closer look later this morning, but I think it's failing because of the two errors being thrown in the pylint
on actions. We could either:
Will take a closer look later this morning, but I think it's failing because of the two errors being thrown in the
pylint
on actions.
I think the pylint_flask_sqlalchemy
dependency I added should fix this (at least it does on my machine). However, it clearly doesn't on the GH action, either because it's malfunctioning or the config in the pyproject.toml
isn't being used for pylint. In any case, just adding the ignores inline is probably easiest.
Will take a closer look later this morning, but I think it's failing because of the two errors being thrown in the
pylint
on actions.I think the
pylint_flask_sqlalchemy
dependency I added should fix this (at least it does on my machine). However, it clearly doesn't on the GH action, either because it's malfunctioning or the config in thepyproject.toml
isn't being used for pylint. In any case, just adding the ignores inline is probably easiest.
Hmm okay, I'll play around with it a little more this morning and see if I can get that part working then.
Proposed changes
Get all our quality checkers passing.
I couldn't get pylint to work properly in pre-commit, but it passes on my machine too.
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!black
with the-l 79
flag.Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
_PR template was adopted from appium_