Refactor afidsvalidator.views.validator for simplicity/shortness, adding a couple of other functions and classes to handle specific functionality. I just had to deal with this function in the quality PR and it struck as ripe for a bit of a refactor.
Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionalitiy)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Other (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!
[ ] Changes have been tested to ensure that fix is effective or that a feature works.
[ ] Changes pass the unit tests
[ ] Code has been run through black with the -l 79 flag.
[ ] I have included necessary documentation or comments (as necessary)
[ ] Any dependent changes have been merged and published
Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
Proposed changes
Refactor
afidsvalidator.views.validator
for simplicity/shortness, adding a couple of other functions and classes to handle specific functionality. I just had to deal with this function in the quality PR and it struck as ripe for a bit of a refactor.Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!black
with the-l 79
flag.Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.
_PR template was adopted from appium_