Closed kaitj closed 5 years ago
Looks great, thanks for the edits! Yeah I'm sure we can add column headings for the Fiducial names / distances. But I think we can do that after integrating @tkkuehn 's CSS to see what will look best
Yep that sounds good to me. They are quick changes anyways for the headings. As for the distances...it only limits it to 5 decimals at the end, so it'll use all trailing numbers during the calculation (not sure how much of a difference that might make).
Multiple changes in this PR - meant to be a patch for #23
Instantiated the
template_data_j
variable withNone
to avoid theUnboundLocalError
it was causing.Renamed a few variables (eg.
jsonData
touser_data
) and changed some capitalizations in the variablesRemoved now unused functions and imports, as well as old comments that no longer apply
Changed the pathing from @ostanley had to pull existing templates from the sub-modules to use os.path.join (this is just a preference, but we can change it back)
Changed the expected labels to match with that shown in the fiducial protocol document (and the readthedocs). @tkkuehn, @Park-Patrick - this will likely break a lot of the test cases and throw errors when trying to perform computations @jclauneuro - the files in the sub-modules we are pulling from have a few differences in the fiducial names than the ones stated in the protocol (eg. splenium vs Splenium of CC). One of the two (the .fcsv files or the protocol) would have to be changed to reflect what it should be and we can make the necessary changes in the code for the expected label. As of this PR, I've changed it to match what is stated in the protocol document
@Park-Patrick I'm wondering if it is possible to put headings to the tables for the calclated distances. At the moment it is one heading that says Distances and then lists the fiducial and euclidean distance all underneath in 2 columns. Maybe we can put something above each column like Fiducial | Distance [mm]. Also how precise do we need the distances? Right now its showing a lot of trailing decimals - if this is important, than we can keep it as is, otherwise maybe for the sake of visualization, we can limit it to the first 4/5 decimals?
EDIT: I've made the changes above regarding the trailing decimals to only 5 decimal places. I also changed the main "Distance" heading to "Result" and placed "Fiducial" and "Distance [mm]" Directly above the corresponding columns. We can make a change to this before merging if we decide we want it slightly different.