search

afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Continuous Integration #55

Closed kaitj closed 4 years ago

kaitj commented 4 years ago

This PR serves a test for the CI workflow. Added a YAML file for CI via github actions:

PRs should not be merged unless:

  1. CI passes
  2. PR has been reviewed.
kaitj commented 4 years ago

PR should be good for review! Looks like everything is now working, including the testing. One thing that I am not entirely sure is how it assigns the reviewers. Looks like it just goes down the list in order as seen in the auto_assign.yml.

Will note this CI only performs testing for the unittest currently written and does not test for site implementations, hence the need for additional review (which should be done anyways). More tests can be written in the future / github actions implemented to perform certain deployments

tkkuehn commented 4 years ago

Alrighty, looks good to me. I'll go ahead and merge this.