search

afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Website dev #63

Closed kaitj closed 4 years ago

kaitj commented 4 years ago

Looking for some comments and insights into modifications for the site.

Will note that the site is probably not mobile friendly, made no implementations for different screen sizes.

tkkuehn commented 4 years ago

Looking good so far! I've got some time today, so I'm going to take a crack at cleaning up the templates a bit by using some template inheritance, and replacing some divs with more semantic elements.

patrick-g-h commented 4 years ago

looks good to me!

kaitj commented 4 years ago

The .gif replacement from @Park-Patrick needs to be fixed. Currently on top of the navigation bar on my screen.

tkkuehn commented 4 years ago

The .gif replacement from @Park-Patrick needs to be fixed. Currently on top of the navigation bar on my screen.

Fixed this, I think. A bit of the custom CSS caused the problem.

tkkuehn commented 4 years ago

In the interest of keeping things simple, I've gotten rid of the milligram CSS framework and migrated anything that depended on it to the Bootstrap equivalent - As a nice bonus, the validator behaves a bit better on mobile now, too.

kaitj commented 4 years ago

Looks good! Only thing is the footer - it looks like it resizes on its own and the github and twitter icons end up on the same line as the text at full screen. Other then that I think it's pretty much ready to merge once we have the landing page stuff (#64)

tkkuehn commented 4 years ago

Only thing is the footer - it looks like it resizes on its own and the github and twitter icons end up on the same line as the text at full screen.

What's the expected behaviour? Shouldn't be hard to adjust if we prefer a different arrangement.

kaitj commented 4 years ago

What's the expected behaviour? Shouldn't be hard to adjust if we prefer a different arrangement.

I think the one that I've seen most is to have the text on one line and then the icons on another. As for the order, not entirely sure.

tkkuehn commented 4 years ago

I added a brief placeholder intro to replace the lorem ipsem that was there before, so I think we can get this merged now.

tkkuehn commented 4 years ago

We're going to take away the "View DB" and "Analytics" buttons for now - they don't really add any value at this point. We're also going to take away the copyright statement, then we'll be good to go.

kaitj commented 4 years ago

Merging current PR as is in order to push updates along. See #66 for removal of "View DB" and "Analytics" buttons.