search

afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Non-human Template #88

Closed kaitj closed 4 years ago

kaitj commented 4 years ago

Proposed changes

Added a non-human .fcsv file for validation testing. Additionally added a test to validate this non-human file. This attempts to address #87. "Validate .fcsv file structure" was not working with non-human templates. This was later determined to be working as intended (see thread), however it was noted that it could be made more obvious that the validator is doing something.

This PR adds in validation testing for non-human template and time stamps to make more obvious that tha validation is working, especially when dropdown menu option isn't changed resulting in the message not changing.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

_PR template was adopted from appium_

kaitj commented 4 years ago

Removing bug label as this is no longer addressing a bug. Added enhancement label to indicate that the new feature (timestamps) added in.

kaitj commented 4 years ago

Marking this as "ready for review", but open to suggestions to address the above noted concern about more obvious working validation.

ostanley commented 4 years ago

I approve, works locally with timestamp in both the nhp file as well as other files including invalid ones (tested extension, rows, and invalid version).