afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Interactive Visualization #89

Closed heatherspacek closed 3 years ago

heatherspacek commented 4 years ago

Proposed changes

Add plotly interactive graphs to the Validator page.

Notes

I have a good idea of the roadmap to fully integrate these, but I don't have the resources right now to test the changes properly myself.

Types of changes

Checklist

_PR template was adopted from appium_

tkkuehn commented 3 years ago

Alrighty, I think this is in shape for a review now.

tkkuehn commented 3 years ago

Notes from today's meeting:

tkkuehn commented 3 years ago

I think this is ready for another review!

tkkuehn commented 3 years ago

Wondering do we want to merge it into master now, or release it as part of 0.2.x?

Either way seems fine to me. We could even merge this, make it 0.2.0, then make the AFIDs class stuff 0.3.0.

kaitj commented 3 years ago

Given that I somehow did some weird thing with creating the AFIDs class and this doesn't actually break functionality with 0.1.x (though it is a major enhancement), I'd be happy with merging this in as 0.1.x and still call the AFIDs class 0.2.x

tkkuehn commented 3 years ago

Great, feel free to merge and tag it as a new release in that case!