Closed heatherspacek closed 3 years ago
Alrighty, I think this is in shape for a review now.
Notes from today's meeting:
I think this is ready for another review!
Wondering do we want to merge it into master now, or release it as part of 0.2.x?
Either way seems fine to me. We could even merge this, make it 0.2.0, then make the AFIDs class stuff 0.3.0.
Given that I somehow did some weird thing with creating the AFIDs class and this doesn't actually break functionality with 0.1.x (though it is a major enhancement), I'd be happy with merging this in as 0.1.x and still call the AFIDs class 0.2.x
Great, feel free to merge and tag it as a new release in that case!
Proposed changes
Add plotly interactive graphs to the Validator page.
Notes
I have a good idea of the roadmap to fully integrate these, but I don't have the resources right now to test the changes properly myself.
generate_visualizations()
(from generate_visualizations.py) should be called in controller.py'svalidator()
(around line 405, maybe?)generate_visualizations()
is equipped to dump working HTML to a file (specified by an argument) - it will be wrapped in a etc but those are easy to trim out. It's approximately 3MB of javascript.render_template()
(the call on line 406 of controller.py currently) can be modified to take another argument similar to the 'result' string, or you can staple the figures to 'result' itself for a convenient way to test without changing any architecture?Types of changes
Checklist
_PR template was adopted from appium_