afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

Internal server error #91

Closed Tanaya9299 closed 4 years ago

Tanaya9299 commented 4 years ago

The problem

I tested the afids protocol and while using the validator I am getting internal error

Environment

_

kaitj commented 4 years ago

Hi there! Could you let us know which dropdown option was selected as well as an example of the .fcsv that was used?

Tanaya9299 commented 4 years ago

2009bMNI_T1_TM_01.txt

kaitj commented 4 years ago

@Tanaya9299 - Thank you. I took a look at the contents of the .txt file. It seems as if there is some mismatch/missing of information in the first two fiducials (AC, PC) which is causing the internal error. I've included below the two lines that are causing this issue.

Original:

vtkMRMLMarkupsFiducialNode_0,0.023,-8.165,-16.415,0.000,0.000,0.000,1.000,1,1,1,AC,,vtkMRMLScalarVolumeNode1
vtkMRMLMarkupsFiducialNode_1,0.536,-25.470,-2.099,0.000,0.000,0.000,1.000,1,1,1,PC,,vtkMRMLScalarVolumeNode1

Replace with:

vtkMRMLMarkupsFiducialNode_0,0.023,-8.165,-16.415,0.000,0.000,0.000,1.000,1,1,1,1,AC,vtkMRMLScalarVolumeNode1
vtkMRMLMarkupsFiducialNode_1,0.536,-25.470,-2.099,0.000,0.000,0.000,1.000,1,1,1,2,PC,vtkMRMLScalarVolumeNode1

Note the two commas following label description (AC, PC) and the missing label (1, 2). This should fix the file to get around the file.

@afids/afids-validator - note to discuss implementation of checking mismatched column contents to columns. This error bypasses current checks and throws an internal error - also replicated on Chrome (83.0.4103.97). There are correct number of columns, however label description (AC) was in the place of label, and description ended up blank.

Tanaya9299 commented 4 years ago

Thank you so much. It worked.

kaitj commented 4 years ago

Opening new issue to move dicussion of the handling of this error. Closing this issue as manually correcting error seen in the .fcsv resolves the server error.