afids / afids-validator

Validator for the anatomical fiducial placement protocol
https://validator.afids.io
GNU General Public License v3.0
2 stars 4 forks source link

BUG: Mismatched fcsv column #93

Closed kaitj closed 3 years ago

kaitj commented 4 years ago

The problem

Moving from #91 to separate issue. Validator throws a server error when the following fcsv is uploaded: 2009bMNI_T1_TM_01.txt.

There appears to be a mismatch of columns / missing information for first two fiducials (AC. PC). See below for the two problematic lines.

vtkMRMLMarkupsFiducialNode_0,0.023,-8.165,-16.415,0.000,0.000,0.000,1.000,1,1,1,AC,,vtkMRMLScalarVolumeNode1
vtkMRMLMarkupsFiducialNode_1,0.536,-25.470,-2.099,0.000,0.000,0.000,1.000,1,1,1,PC,,vtkMRMLScalarVolumeNode1

Note the two commas following label description (AC, PC) and missing label (1, 2).

NA: To discuss potential implementation of mismatched columns. Currently, this error bypasses current checks. Correct number of columns, but label description was in the place of label, and description is empty.

Environment

_PR template was adopted from appium_

kaitj commented 4 years ago

After discussion during meeting, error may have stemmed from misnamed fields in Slicer. Two checks to be implemented:

  1. Ensure label / name field is a number.
  2. Label description is a string