search

afilipovich / gglsbl

Python client library for Google Safe Browsing API
Apache License 2.0
83 stars 37 forks source link

500 hash limit per API request to /v4/fullHashes:find #44

Closed colonelxc closed 5 years ago

colonelxc commented 5 years ago

This came up in google/safebrowsing#87. I believe it affects this project as well.

In short, there is a 500 hash limit on fullHashes:find requests. Unfortunately this is not currently documented in the developer docs (I'll make sure they're fixed soon).

I just wanted to give you a heads up before someone using this client runs into the problem. This limit has been in place for well over a year, so it seems it hasn't caused much trouble until now.

afilipovich commented 5 years ago

Hi @colonelxc, thanks for heads up! Currently gglsbl does one full fullHashes:find query per URL. Single URL typically translates to a few hash prefixes and is not likely to ever reach 500 (that would take a 400-level subdomain).

I was considering batching fullHash searches into a single request to reduce number of API calls, but given that there is a limitation it is better to keep it as it is.

colonelxc commented 5 years ago

Ah, great! I misread the code earlier.