afilipovich / gglsbl

Python client library for Google Safe Browsing API
Apache License 2.0
83 stars 37 forks source link

minimumWaitDuration should be separated for for get_threats_update and get_full_hashes #50

Closed wiebren closed 1 year ago

wiebren commented 3 years ago

There is currently a single wait period for all calls, however the docs mention the minimumWaitDuration is separate per call type:

https://developers.google.com/safe-browsing/v4/reference/rest/v4/threatListUpdates/fetch

The minimum duration the client must wait before issuing any update request. If this field is not set clients may update as soon as they want.

https://developers.google.com/safe-browsing/v4/reference/rest/v4/fullHashes/find

The minimum duration the client must wait before issuing any find hashes request. If this field is not set, clients can issue a request as soon as they want.

Also get_threats_lists has handling for minimumWaitDuration, but the docs do not mention this response field in the threatLists.list call

https://developers.google.com/safe-browsing/v4/reference/rest/v4/threatLists/list

afilipovich commented 1 year ago

Thanks @YoitoFes