keeping a reference to the context statically

afiqiqmal / SharedChamber

Android Secure SharedPreferences Using Facebook Conceal Encryption

MIT License

95 stars 13 forks source link

keeping a reference to the context statically #1

Closed itaybia closed 6 years ago

itaybia commented 7 years ago

Hi, i may have it wrong, but from the code it seems like the context passed to the PreferencesBuilder is saved statically inside ConcealPrefRepository.concealCrypto. this may cause memory issues since the context will not be released. you may want to use the application context or a weak reference perhaps.