search

afiskon / stm32-ssd1306

STM32 library for working with OLEDs based on SSD1306, SH1106, SH1107 and SSD1309, supports I2C and SPI
https://eax.me/stm32-ssd1306/
MIT License
740 stars 206 forks source link

Slight changes and some features added #56

Closed Jojo-A closed 2 years ago

Jojo-A commented 2 years ago

Hi, please have a look at the changes I made. They might make your library even more versatile. Feel free to give me feedback, I'd look forward to see me changes merged into your project :) .

afiskon commented 2 years ago

I'm sorry but I failed to see any real value in the proposed changes.

afiskon commented 2 years ago

I don't mind renaming all the procedures to ssd1306_Draw* for consistency, but in this case you have to rename ssd1306_Polyline() as well.

Jojo-A commented 2 years ago

I don't mind renaming all the procedures to ssd1306_Draw* for consistency, but in this case you have to rename ssd1306_Polyline() as well.

Thats totally true. I have just overseen it...

I personally think that drawing triangles could indeed be useful to someone (as rectangles are). Additionally I think that the "Inversion" color thing is cool, because one can draw things over each other (for example text over a graphic) and it will still be readable (that how I use it). But I am not here to argue about my proposals after they have already been rejected.

Thanks for your work anyway.

afiskon commented 2 years ago

@Jojo-A OK, now I see your point. This makes sense. I don't mind these changes, but please submit them one by one and provide meaningful commit messages.

Jojo-A commented 2 years ago

@Jojo-A OK, now I see your point. This makes sense. I don't mind these changes, but please submit them one by one and provide meaningful commit messages.

Okay, thank you. I will do so.