search

afiskon / stm32-ssd1306

STM32 library for working with OLEDs based on SSD1306, SH1106, SH1107 and SSD1309, supports I2C and SPI
https://eax.me/stm32-ssd1306/
MIT License
740 stars 206 forks source link

Add more draw functions #59

Closed muhammadrefa closed 1 year ago

muhammadrefa commented 1 year ago

Added more draw functions:

Drawing functions derived from and made using (currently) available functions. Does not know about the performance (considering (almost) all drawing functions are using ssd1306_DrawPixel() function that write everything per bit instead of byte)

afiskon commented 1 year ago

Thanks for the PR. I didn't had time to test it yet, but all in all it looks OK. I think I'm going to make time somewhere this week.

afiskon commented 1 year ago

@muhammadrefa could you please add the calls of the new functions to ssd1306_TestAll()? This would simplify testing with different OLEDs a lot, including regression testing in the future. (See examples/oled-tester)

muhammadrefa commented 1 year ago

I have not tested the tests using the real oled and stm32 yet, but it looks good in my console. I'll let you know if I have tested it on the stm32

muhammadrefa commented 1 year ago

I have tested the tests using oled in stm32 and it looks good

afiskon commented 1 year ago

LGTM, merged. Many thanks for the contribution!