Peer to Peer code review morning session

afizsavage / todo-list

This is a simple todo list application

4 stars 0 forks source link

Peer to Peer code review morning session #7

Open MeqdamAlqudah opened 2 years ago

MeqdamAlqudah commented 2 years ago

great work Afiz I liked the UI design and the colors 👍 but it would be great to work on these issues 💯 1-the remove button doesn't work for each item in the to-do list. 2-the window. reload() is making the website too slow .

afizsavage commented 2 years ago

Thanks, @MeqdamAlqudah :+1:

The delete icon is not a button, its purpose is to inform the user that she can delete the todo while the edit input field is active. If the user press enter while the input field is active and the value of the input field is an empty string the item gets deleted

I made a short screencast of how the original todo app that we are supposed to clone implement the feature.

MeqdamAlqudah commented 2 years ago

@afizsavage okay, bro nice work 👍 but I think it would be simpler if it is a button i.e (DRY, KISS, and YAGNI )

afizsavage commented 2 years ago

Thanks, @MeqdamAlqudah.

I'm seriously considering adding the functionality.