search

afkcodes / flutter_phosphor_icons

Phosphor Icons for Flutter.
https://pub.dev/packages/flutter_phosphor_icons
MIT License
15 stars 4 forks source link

Migrate to NNBD #2

Closed raulmabe closed 3 years ago

raulmabe commented 3 years ago

Just needed to upgrade the dart sdk to min 2.12.0 in the pubspec.yaml:

environment:
  sdk: ">=2.12.0 <3.0.0"

Then I run dart migrate tool:

dart migrate
  ╔════════════════════════════════════════════════════════════════════════════╗
  ║ The Dart tool uses Google Analytics to anonymously report feature usage    ║
  ║ statistics and to send basic crash reports. This data is used to help      ║
  ║ improve the Dart platform and tools over time.                             ║
  ║                                                                            ║
  ║ To disable reporting of anonymous analytics, run:                          ║
  ║                                                                            ║
  ║   dart --disable-analytics                                                 ║
  ║                                                                            ║
  ╚════════════════════════════════════════════════════════════════════════════╝

Migrating /Users/mabe/Documents/flutter_phosphor_icons

See https://dart.dev/go/null-safety-migration for a migration guide.

Note: more than one project found; migrating the top-level project.

Analyzing project...
[-------------\]
All sources appear to be already migrated.  Nothing to do.
raulmabe commented 3 years ago

Also, the package version should be updated as the guidelines says:

Package version Update the version of the package to indicate a breaking change:

If your package is already at 1.0.0 or greater, increase the major version. For example, if the previous version is 2.3.2, the new version is 3.0.0.

If your package hasn’t reached 1.0.0 yet, either increase the minor version or update the version to 1.0.0. For example, if the previous version is 0.3.2, the new version is either 0.4.0 or 1.0.0.

Before you publish a stable null safety version of a package, we strongly recommend following these pubspec rules:

Set the Dart lower SDK constraint to 2.12.0. Use stable versions of all direct dependencies.

afkcodes commented 3 years ago

@raulmabe Thanks for the PR, just for my information have you tested it once if yes we can merge this and make a release.

raulmabe commented 3 years ago

I run the example/ app with NNBD and had no problems/warnings at all

afkcodes commented 3 years ago

cool merging this then Thanks @raulmabe