search

afkcodes / flutter_phosphor_icons

Phosphor Icons for Flutter.
https://pub.dev/packages/flutter_phosphor_icons
MIT License
15 stars 4 forks source link

Updated files to add 1254 more icons #3

Closed raulmabe closed 3 years ago

raulmabe commented 3 years ago

I noticed there were some icons in the official web (i.e. graduation_cap) I intended to use in my app, so I updated the source icon files and rerun the script to add 418 icons, with a total of 1254 icon variations.

I check on the example/ app if the new ones work and they do

afkcodes commented 3 years ago

Thanks @raulmabe This is pretty cool. just testing it out on my side and merging it. Thanks again.

afkcodes commented 3 years ago

seems like scss has also been added it was not there, when i created this package.

raulmabe commented 3 years ago

So the .scss file was there, but I deleted the old one and inserted an updated .css

afkcodes commented 3 years ago

@raulmabe can you just format the dart file seems like formatting if off.

raulmabe commented 3 years ago

Yeah it was off, I will push the formatted version. Also I noticed there are some weird icons in the source file phosphor-codes.css I downloaded from their website that are not on the website... (i.e. PhosphorIcons.SF400000)

I am doing some testing with them at the moment... Maybe we'll need to delete them

afkcodes commented 3 years ago

gotcha, may be because the changes in script it is happening please check the script and try to use scss, i personally don't think we need to change anything in script.

raulmabe commented 3 years ago

The script works well. The "problem" is that the new .css file carries some glyphs like this one. These glyphs do not have different tones, however I think they may be useful to some people working with algebra or others.

afkcodes commented 3 years ago

@raulmabe it seems i am unable to check your branch some issue from my side can you please confirm if all things are right and good to go ?

raulmabe commented 3 years ago

What issues do you have encountered? I am using my fork in one of my projects and I am not having any issue

afkcodes commented 3 years ago

its not related to the the repo its github seems like some mis-configuration has happened.

afkcodes commented 3 years ago

Merged & Updated at pub.dev Thanks @raulmabe