aflaag / pokemon-icat

Shows any Pokémon sprite in your terminal!
GNU General Public License v3.0
100 stars 6 forks source link

make http requests asynchronous #3

Closed imsamuka closed 2 years ago

imsamuka commented 2 years ago

Implementation of #2. I introduced some global variables. Some, you can parameterize, others, you can't. Also, there's some magic numbers there, which you can create constants for. I removed the try-except from #1. You can reintroduce it, but i REALLY don't recommend you do it in the same way as before. You can also use a numpy array to store the pokemon names, i guess. It should be better.