search

aflaag / pokemon-icat

Shows any Pokémon sprite in your terminal!
GNU General Public License v3.0
95 stars 6 forks source link

Wrong command in .pokemon-icat.sh #9

Closed Sommerrolle closed 10 months ago

Sommerrolle commented 10 months ago

This command in line 14 of file pokemon-icat.sh did not work for me: kitten icat --align left --silent $HOME/.pokemon-icat/pokemon-icons/$pokemon.png

I changed it to kitty +kitten icat --align left --silent $HOME/.pokemon-icat/pokemon-icons/$pokemon.png

I don't know is this is a change from the kitty terminal itself. Just wanted to mention it if someone else had a similar problem :)

kovidgoyal commented 10 months ago

kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well.

aflaag commented 10 months ago

kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well.

so, do you suggest me to change that line to make sure it works on older versions as well?

kovidgoyal commented 10 months ago

On Wed, Sep 06, 2023 at 08:26:53AM -0700, Alessio Bandiera wrote:

kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well.

so, do you suggest me to change that line to make sure it works on older versions as well?

It's a bit slower as kitty +kitten icat will end up calling kitten icat but not significantly, so its up to you if the tradeoff is worth it.

aflaag commented 10 months ago

On Wed, Sep 06, 2023 at 08:26:53AM -0700, Alessio Bandiera wrote: > kitten icat is correct for modern kitty, kitty +kitten icat is needed only for older kitty releases, but will work on newer ones as well. so, do you suggest me to change that line to make sure it works on older versions as well? It's a bit slower as kitty +kitten icat will end up calling kitten icat but not significantly, so its up to you if the tradeoff is worth it.

ok, thank you!