search

aflux / neutrino

A light, expandable and full featured image analysis tool for research
10 stars 1 forks source link

phase vs. fringeshift #21

Closed iltommi closed 10 years ago

iltommi commented 10 years ago

what is labeled "phase" in the wavelet analysis is rather "fmod(fringeshift,1)". I propose to rename phase with fringeshift in the GUI and nPhysImage

aflux commented 10 years ago

It's true that calling it phase without any further explanation it's definitely misleading.

However I don't find "fringeshift" so much self-explanatory, since you don't specify the unit...

Shouldn't we just write very big "phase/2pi" ?

On 03/11/2014 02:50 PM, iltommi wrote:

what is labeled "phase" in the wavelet analysis is rather "fmod(fringeshift,1)". I propose to rename phase with fringeshift in the GUI and nPhysImage

— Reply to this email directly or view it on GitHub https://github.com/aflux/neutrino/issues/21.

iltommi commented 10 years ago

ok I'll do it

On Tue Mar 11 17:17:05 2014, aflux wrote:

It's true that calling it phase without any further explanation it's definitely misleading.

However I don't find "fringeshift" so much self-explanatory, since you don't specify the unit...

Shouldn't we just write very big "phase/2pi" ?

On 03/11/2014 02:50 PM, iltommi wrote:

what is labeled "phase" in the wavelet analysis is rather "fmod(fringeshift,1)". I propose to rename phase with fringeshift in the GUI and nPhysImage

— Reply to this email directly or view it on GitHub https://github.com/aflux/neutrino/issues/21.

— Reply to this email directly or view it on GitHub https://github.com/aflux/neutrino/issues/21#issuecomment-37314959.