afomera / trix

Easily drop the Trix WYSIWYG editor into your Ruby on Rails application.
MIT License
87 stars 29 forks source link

Change to version numbers? #4

Closed kylefox closed 6 years ago

kylefox commented 6 years ago

The original version of this gem followed the same version numbers as Trix itself.

The problem with this approach is that it makes it difficult to release new features and bug fixes independently of Trix. For example: if Trix and trix-rails are both at v.0.11.4, and a bug is then fixed in trix-rails, what happens to the version number?

I think the solution is to allow Trix and trix-rails version numbers to diverge. trix-rails would follow it's own SemVer, and would also increment major/minor/patch versions alongside Trix.

Some examples:

Patch

Minor

Does this seem like a reasonable approach?

Schwad commented 6 years ago

Just my two cents here. I think this is a reasonable approach. We increment on our own improvements/changes and bump as well with main trix. Sounds good to me! :thumbsup:

kylefox commented 6 years ago

Ok, we're now officially decoupled from Trix's own versioning scheme 🙌

trix-rails 1.0.0 has been released, and a changelog has been added.