afonasev / flake8-return

Flake8 plugin for return expressions checking.
MIT License
62 stars 69 forks source link

Create v1.1.3 tag #126

Closed calumy closed 1 year ago

calumy commented 1 year ago

Description

I was updating our pre-commit hooks to use flake8-return (rather than a forked version), but as the v1.1.3 tag has not been created on Github, the pre-commit hook does not make use of the changes introduced in v1.1.3 on PyPI.

@afonasev, please could you create a tag for v1.1.3 so that pre-commit makes use of the recent updates?

What I Did

The abridged pre-commit config used below throws a false positive for R504, which has been fixed in the version released on PyPI.

repos:
  ...
  - repo: https://github.com/PyCQA/flake8
    rev: 5.0.4
    hooks:
      - id: flake8
        additional_dependencies:
          - flake8-return
          ...
        args: [--config, setup.cfg]
calumy commented 1 year ago

@afonasev. Thanks for doing that so quickly! Closing as complete.

afonasev commented 1 year ago

Thanks for your issue!)

calumy commented 1 year ago

Apologies, I think I closed this prematurely.

It appears that v1.2.0 is the release that fixes the false positive that we were getting but this version is not currently on PyPI. Would it be possible to publish v1.2.0 on PyPI?

afonasev commented 1 year ago

done https://pypi.org/project/flake8-return/1.2.0/

calumy commented 1 year ago

Thank you very much!