Flutter 3.0.0 is detecting issue with the library

afonsocraposo / buttons_tabbar

A Flutter package that implements a TabBar where each label is a toggle button.

https://pub.dev/documentation/buttons_tabbar/latest/

MIT License

103 stars 34 forks source link

Flutter 3.0.0 is detecting issue with the library #27

Closed RoyalCoder88 closed 2 years ago

RoyalCoder88 commented 2 years ago

../../../Documents/flutter/.pub-cache/hosted/pub.dartlang.org/buttons_tabbar-1.3.4/lib/buttons_tabbar.dart:180:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Documents/flutter/packages/flutter/lib/src/widgets/binding.dart'). WidgetsBinding.instance

gslender commented 2 years ago

I've made the 1 line change in the code published in a fork I created, and added this to my pubspec.yaml

  # buttons_tabbar: ^1.3.4 # NOT V3 COMPATIBLE
  buttons_tabbar: #1.3.5 
    git:
      url: https://github.com/gslender/buttons_tabbar.git

When/if the package author gets around to updating, it is a simple change back in the pubspec

afonsocraposo commented 2 years ago

Hi @gslender! Do you wanna make a pull request?

gslender commented 2 years ago

It's one line. I'm sure you can figure it out

afonsocraposo commented 2 years ago

Of course. I asked you because you might wanted to be associated with that commit. Nevertheless, I'll update the package. Thank you.

gslender commented 2 years ago

Thanks mate, but for such a small change, and the chance that you might be a fussy bugger that makes the effort worthless... I'm happy for you to own that 🤣

I just wanted a way to make the warnings go away... 🤣🤣

afonsocraposo commented 2 years ago

No problem! Thanks @gslender. @RoyalCoder88 it should be fixed now, use version 1.3.5.