afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.72k stars 355 forks source link

SSL certificate is broken rendering them useless #105

Closed ssbarnea closed 7 years ago

ssbarnea commented 7 years ago

It seems that SSL certificates is brokened, which makes the "CDN" useless: https://afonsof.com/jenkins-material-theme/dist/material-brown.css

otherguy commented 7 years ago

This really needs to be fixed.

afonsof commented 7 years ago

afonsof.com/jenkins-material-theme is hosted at GitHub and is a shortcut for afonsof.github.io/jenkins-material-theme. I bought a certificate for the domain afonsof.com however this is not working properly because this shortcut. Anyone with experience in this area can help me?

ssbarnea commented 7 years ago

I would host it on S3 as you can get SSL for free and real-reliability. The cost of hosting these files would probably be smaller than a certificate anyway. Also, if you use S3 you can also log the requests in case you want to get some analytics after that.

otherguy commented 7 years ago

Or forget the custom domain and use SSL on GitHub pages. https://konklone.com/post/github-pages-now-sorta-supports-https-so-use-it

ssbarnea commented 7 years ago

@darkwinternight Indeed, another place where less (complexity) is more (reliability). There is only one serious requirement from the users: valid (recognized) SSL on the CDN, that's the only way to assure that we can load the theme.

frekele commented 7 years ago

You can use the github domain, simply like this:

https://raw.githubusercontent.com/

https://raw.githubusercontent.com/afonsof/jenkins-material-theme/gh-pages/dist/material-red.css

otherguy commented 7 years ago

Yes @frekele, that is what most people are probably doing now. It seems that @afonsof wants a custom domain though.

afonsof commented 7 years ago

In fact I just want everything working @darkwinternight. So all we need to do is to change the docs to point to raw.github... excellent idea @frekele!

afonsof commented 7 years ago

Changed in the docs. Please use https://raw.githubusercontent.com/afonsof/jenkins-material-theme/gh-pages/dist/material-{{your-color-name}}.css