afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.72k stars 355 forks source link

Since Jenkins 2.246 - headers became black #177

Open unickq opened 4 years ago

unickq commented 4 years ago

Expected

image

Actual

image

timbrown5 commented 4 years ago

Hi @unickq,

I have managed to work around this locally by updating the style sheet with the following (I added it to the end of mine):

:root {
    /* Table */
    --bigtable-header-bg: var(--light-grey);
    --bigtable-header-border-color: var(--light-grey);
    --bigtable-header-text-color: var(--dark-grey);
    --bigtable-row-border-color: var(--light-grey);
    /* Remove if you don't light the alternating coloured rows */
    --even-row-color: var(--very-light-grey);
    --table-striped-bg--hover: var(--very-light-grey);

    /* Tab bar widget */
    --tab-link-border-color: var(--light-grey);;
    --tab-link-text-color: var(--dark-grey);
    --tab-link-checked-bg: var(--light-grey);
    --tab-link-checked-text-color: var(--dark-grey);
    --tab-link-bg--hover: var(--light-grey);
    --tab-link-bg--active: var(--light-grey);
}

It overwrites the variables set in theme.less, which is provided with newer versions of Jenkins (I am using 2.249.1). This gets the theme back more how I remember it (but I could have picked the wrong types of grey). For some background --very-light-grey, --light-grey, --dark-grey, are all variables defined in theme.less and (I believe) they form the basis of the default colour pallet. There is also --medium-grey, --white and --black.

With this applied I get: Screenshot 2020-09-13 at 18 11 30

I hope this helps, Tim

fkranenburg commented 4 years ago

Same issue here, thanks for the workaround @timbrown5 !

ozonni commented 4 years ago

would be great to have PR to get it fixed for everyone

maxbanton commented 2 years ago

This works for me https://jorg3lucas.github.io/jenkins-modern-themes/