afonsof / jenkins-material-theme

Beautify your Jenkins with the Material Design theme!
http://afonsof.com/jenkins-material-theme
MIT License
1.73k stars 357 forks source link

the in-progress icon float layer out #183

Open marslo opened 3 years ago

marslo commented 3 years ago

Jenkins version: 2.284/2.283 simple theme plugin version: 0.6 material theme: 0.3.2

The running icon shows up:

after using Jenkins default theme:

starwarsfan commented 3 years ago

Second that, same here.

Smasherr commented 3 years ago

@starwarsfan I thought it was a feature 🤣

mit4ever commented 3 years ago

Metoo, maybe problem is jenkins

marslo commented 3 years ago

Metoo, maybe problem is jenkins

Jenkins default theme works well with the "in progress" status icon. So that quite unlikely is the issue of Jenkins.

mit4ever commented 3 years ago

Metoo, có thể vấn đề là jenkins

Chủ đề mặc định của Jenkins hoạt động tốt với biểu tượng đang chạy. Vì vậy, điều đó khá khó xảy ra là vấn đề của Jenkins.

I agree. Used to be fine but when I recently updated jenkins there was a problem with icon

marslo commented 3 years ago

well... I've using workaround bypass the issue :

svg[class*=anime] { visibility: collapse }

btw, using hidden as the same as the collapse.

Details:

it can be setup in Jenkins via:

simple-theme-7
Smasherr commented 3 years ago

Nice job @marslo! Would be cool to see a PR for this

marslo commented 3 years ago

Nice job @marslo! Would be cool to see a PR for this

this is actually the workaround, just hidden the overlayer svg image...

fguillotpro commented 3 years ago

Still happening with Jenkins 2.293 and jenkins-material-theme.css v.1.3.3, any news on that matter? Thanks

eplodn commented 3 years ago

Implemented the workaround (thanks @marslo !) but it would be great if @afonsof or somebody could fix the underlying issue.

offa commented 3 years ago

Related Jenkins Issue: JENKINS-65808

offa commented 3 years ago

The issue has hit other themes too: https://github.com/TobiX/jenkins-neo2-theme/issues/40

pboiseau commented 2 years ago

Hello, thank you for the workaround.

If anyone want to set up it using groovy script, here is the script I use

import jenkins.model.Jenkins
import org.jenkinsci.plugins.simpletheme.CssUrlThemeElement
import org.jenkinsci.plugins.simpletheme.CssTextThemeElement

Jenkins jenkins = Jenkins.get()

def themeDecorator = jenkins.getExtensionList(org.codefirst.SimpleThemeDecorator.class).first()

themeDecorator.setElements([
        new CssUrlThemeElement('https://cdn.rawgit.com/afonsof/jenkins-material-theme/gh-pages/dist/material-indigo.css'),
        // fix jenkins theme issue https://github.com/afonsof/jenkins-material-theme/issues/183#issuecomment-806518351
        new CssTextThemeElement('svg[class*=anime] { visibility: collapse }')
])

jenkins.save()
abstract-entity commented 2 years ago

well... I've using workaround bypass the issue :

svg[class*=anime] { visibility: collapse }

btw, using hidden as the same as the collapse.

Details:

it can be setup in Jenkins via: simple-theme-7

Thanks, it do the job

jiuhuche120 commented 2 years ago

ths